Don't propagate a full verification scheduler out of HandleMessage - #588
Merged
Merged
Conversation
processFinalizedBlock and processNotarizedBlock returned ErrTooManyPendingVerifications straight up through processReplicationState and handleReplicationResponse to Epoch.HandleMessage, surfacing it to the embedding application. A full scheduler is backpressure, not a fatal error. Both now log and drop the block, matching how the proposal path already handles a failed schedule. Other errors still propagate. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
samliok
marked this pull request as ready for review
September 9, 2026 16:31
Collaborator
|
what about the non-validator? |
Collaborator
Author
I could add but i dont think its likely to happen for a non-validator. We only schedule blocks that are nextSeqToCommit, so if our block scheduler is full something else is probably wrong |
yacovm
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude noted this as different then how we handle block messages and I agreed